Bug 130956 - WebKitPerfMonitor: Sometimes text inside panes overlap
Summary: WebKitPerfMonitor: Sometimes text inside panes overlap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 130957
  Show dependency tree / graph
 
Reported: 2014-03-30 21:55 PDT by Ryosuke Niwa
Modified: 2014-03-30 23:39 PDT (History)
8 users (show)

See Also:

Attachments
Revamped the pane UI (12.21 KB, patch)
2014-03-30 22:21 PDT, Ryosuke Niwa 		gyuyoung.kim: review+
rniwa: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-03-30 21:55:25 PDT 
Sometimes build info such as build time, repository names and revision numbers overlap with summary table (the table showing current, baseline, & target).
Cleanup the UI to prevent this from happening.
Comment 1 Ryosuke Niwa 2014-03-30 22:21:56 PDT 
Created attachment 228148 [details]
Revamped the pane UI
Comment 2 Gyuyoung Kim 2014-03-30 22:57:04 PDT 
Comment on attachment 228148 [details]
Revamped the pane UI

rs=me.
Comment 3 Zoltan Horvath 2014-03-30 22:58:06 PDT 
Comment on attachment 228148 [details]
Revamped the pane UI

View in context: https://bugs.webkit.org/attachment.cgi?id=228148&action=review

Useful change, 2 comments.

> Websites/perf.webkit.org/ChangeLog:10
> +        reduces the total height of the pane and fits more information per screen capita on the dashboard.

typo

> Websites/perf.webkit.org/ChangeLog:27
> +        (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.

I'll add this to the wiki page for having a place where we can refer if there's a question.
Comment 4 Ryosuke Niwa 2014-03-30 23:39:55 PDT 
Committed r166479: <http://trac.webkit.org/changeset/166479>