Bug 130955 – [WebGL][OpenGLES] Enable MSAA support for WebGL Canvas

• Component: WebGL
• Status: RESOLVED FIXED

[Byungseon(Sun) Shin]

[WebGL][OpenGLES]Enable MSAA support for WebGL Canvas

[Byungseon(Sun) Shin]

Created attachment 228146 [details]
Patch

[WebKit Commit Bot]

Attachment 228146 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Extensions3D.h:116:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 228146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228146&action=review

It would be great if we could write a test for this.

> Source/WebCore/ChangeLog:10
> +        - Imagination OpenGLES GPU Driver alreay support MSAA, so we

Typo: already

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:118
> +        GLint sampleCount = std::min(8, maxSampleCount);
> +        if (sampleCount > maxSampleCount)
> +            sampleCount = maxSampleCount;

You don't need the if clause. sampleCount is already less than or equal to maxSampleCount.

[Byungseon(Sun) Shin]

Created attachment 228225 [details]
Patch

[WebKit Commit Bot]

Attachment 228225 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Extensions3D.h:116:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Byungseon(Sun) Shin]

Created attachment 228226 [details]
Patch

[Byungseon(Sun) Shin]

@Dean, thanks for the review. 
About creating test case for it, I promise to do it as a separate commit.
Because it might need more work to do. :)

[WebKit Commit Bot]

Attachment 228226 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/Extensions3D.h:116:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:117:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:118:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/Extensions3D.h:119:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 228226 [details]
Patch

Clearing flags on attachment: 228226

Committed r166563: <http://trac.webkit.org/changeset/166563>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.