Bug 130945

Summary:

[Cocoa] Add an originatingWebView property to _WKDownload

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andy Estes 2014-03-30 13:13:23 PDT

[Cocoa] Add an originatingWebView property to _WKDownload

Comment 1 Andy Estes 2014-03-30 13:21:38 PDT

Created attachment 228129 [details]
Patch

Comment 2 Anders Carlsson 2014-03-30 15:08:23 PDT

Comment on attachment 228129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228129&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:248
> +    _webView.clear();

Please use = nullptr here instead.

Comment 3 Andy Estes 2014-03-30 15:25:36 PDT

Created attachment 228133 [details]
Patch

Comment 4 Andy Estes 2014-03-30 15:27:42 PDT

(In reply to comment #2)
> (From update of attachment 228129 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228129&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:248
> > +    _webView.clear();
> 
> Please use = nullptr here instead.

Thanks! Will do.

I uploaded a new patch before I saw your review, but the only difference is that I'm initializing allowOverwrite to NO in DownloadClient::decideDestinationWithSuggestedFilename().

Comment 5 Andy Estes 2014-03-30 15:34:24 PDT

Committed r166466: <http://trac.webkit.org/changeset/166466>

Comment 6 Benjamin Poulain 2014-03-30 19:24:54 PDT

Two APIs tests are failing after this. Can you please have a look?

Comment 7 Andy Estes 2014-03-30 19:38:36 PDT

(In reply to comment #6)
> Two APIs tests are failing after this. Can you please have a look?

http://trac.webkit.org/changeset/166470 should fix them.