Bug 130945

Summary: [Cocoa] Add an originatingWebView property to _WKDownload
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2014-03-30 13:13:23 PDT
[Cocoa] Add an originatingWebView property to _WKDownload
Attachments
Patch (18.94 KB, patch)
2014-03-30 13:21 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (19.90 KB, patch)
2014-03-30 15:25 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2014-03-30 13:21:38 PDT
Created attachment 228129 [details] Patch
Anders Carlsson
Comment 2 2014-03-30 15:08:23 PDT
Comment on attachment 228129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228129&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:248 > + _webView.clear(); Please use = nullptr here instead.
Andy Estes
Comment 3 2014-03-30 15:25:36 PDT
Created attachment 228133 [details] Patch
Andy Estes
Comment 4 2014-03-30 15:27:42 PDT
(In reply to comment #2) > (From update of attachment 228129 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228129&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:248 > > + _webView.clear(); > > Please use = nullptr here instead. Thanks! Will do. I uploaded a new patch before I saw your review, but the only difference is that I'm initializing allowOverwrite to NO in DownloadClient::decideDestinationWithSuggestedFilename().
Andy Estes
Comment 5 2014-03-30 15:34:24 PDT
Committed r166466: <http://trac.webkit.org/changeset/166466>
Benjamin Poulain
Comment 6 2014-03-30 19:24:54 PDT
Two APIs tests are failing after this. Can you please have a look?
Andy Estes
Comment 7 2014-03-30 19:38:36 PDT
(In reply to comment #6) > Two APIs tests are failing after this. Can you please have a look? http://trac.webkit.org/changeset/166470 should fix them.
Note You need to log in before you can comment on or make changes to this bug.