Bug 130936

Summary: [GTK] Use PROJECT_VERSION_* instead of WEBKIT_*_VERSION
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bunhere, cgarcia, commit-queue, gustavo, gyuyoung.kim, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2014-03-29 15:17:39 PDT
These are the common CMake project version variables and using them makes the build a bit less confusing.
Attachments
Patch (5.14 KB, patch)
2014-03-29 23:35 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-03-29 23:35:35 PDT
Created attachment 228121 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-29 23:37:34 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2014-03-31 07:39:03 PDT
Comment on attachment 228121 [details] Patch Clearing flags on attachment: 228121 Committed r166499: <http://trac.webkit.org/changeset/166499>
Martin Robinson
Comment 4 2014-03-31 07:39:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.