|Summary:||[CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest|
|Product:||WebKit||Reporter:||Javier Fernandez <jfernandez>|
|Component:||Layout and Rendering||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, darin, jfernandez, rego, svillar|
|Version:||528+ (Nightly build)|
Description Javier Fernandez 2014-03-29 14:01:59 PDT
Comment 2 Darin Adler 2014-04-01 13:52:44 PDT
Comment on attachment 228282 [details] Patch Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Seems worth double checking that all of this test really works and doesn’t spill outside that window size.
Comment 3 WebKit Commit Bot 2014-04-01 14:23:21 PDT
Comment on attachment 228282 [details] Patch Clearing flags on attachment: 228282 Committed r166610: <http://trac.webkit.org/changeset/166610>
Comment 4 WebKit Commit Bot 2014-04-01 14:23:24 PDT
All reviewed patches have been landed. Closing bug.
Comment 5 Javier Fernandez 2014-04-01 15:33:56 PDT
(In reply to comment #2) > (From update of attachment 228282 [details]) > Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Seems worth double checking that all of this test really works and doesn’t spill outside that window size. I've checked it out and you are right, changes outside that window size are not detected by the reftest. I've filed the bug #131064 to track this issue and will provide a patch soon.