Bug 130935

Summary: [CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, jfernandez, rego, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Javier Fernandez
Reported 2014-03-29 14:01:59 PDT
The grid-item-margin-auto-columns-rows.html is currently implemented using the "check-layout" javascript function, which provides not very descriptive results in the expected file. It would be good to change this test, perhaps others too, to reftest.
Attachments
Patch (17.40 KB, patch)
2014-04-01 06:40 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2014-04-01 06:40:46 PDT
Created attachment 228282 [details] Patch
Darin Adler
Comment 2 2014-04-01 13:52:44 PDT
Comment on attachment 228282 [details] Patch Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Seems worth double checking that all of this test really works and doesn’t spill outside that window size.
WebKit Commit Bot
Comment 3 2014-04-01 14:23:21 PDT
Comment on attachment 228282 [details] Patch Clearing flags on attachment: 228282 Committed r166610: <http://trac.webkit.org/changeset/166610>
WebKit Commit Bot
Comment 4 2014-04-01 14:23:24 PDT
All reviewed patches have been landed. Closing bug.
Javier Fernandez
Comment 5 2014-04-01 15:33:56 PDT
(In reply to comment #2) > (From update of attachment 228282 [details]) > Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Seems worth double checking that all of this test really works and doesn’t spill outside that window size. I've checked it out and you are right, changes outside that window size are not detected by the reftest. I've filed the bug #131064 to track this issue and will provide a patch soon.
Note You need to log in before you can comment on or make changes to this bug.