Bug 130935 - [CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
Summary: [CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a ref...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-29 14:01 PDT by Javier Fernandez
Modified: 2014-04-01 15:33 PDT (History)
5 users (show)

See Also:


Attachments
Patch (17.40 KB, patch)
2014-04-01 06:40 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2014-03-29 14:01:59 PDT
The grid-item-margin-auto-columns-rows.html is currently implemented using the "check-layout" javascript function, which provides not very descriptive results in the expected file. 

It would be good to change this test, perhaps others too, to reftest.
Comment 1 Javier Fernandez 2014-04-01 06:40:46 PDT
Created attachment 228282 [details]
Patch
Comment 2 Darin Adler 2014-04-01 13:52:44 PDT
Comment on attachment 228282 [details]
Patch

Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Seems worth double checking that all of this test really works and doesn’t spill outside that window size.
Comment 3 WebKit Commit Bot 2014-04-01 14:23:21 PDT
Comment on attachment 228282 [details]
Patch

Clearing flags on attachment: 228282

Committed r166610: <http://trac.webkit.org/changeset/166610>
Comment 4 WebKit Commit Bot 2014-04-01 14:23:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Javier Fernandez 2014-04-01 15:33:56 PDT
(In reply to comment #2)
> (From update of attachment 228282 [details])
> Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Seems worth double checking that all of this test really works and doesn’t spill outside that window size.

I've checked it out and you are right, changes outside that window size are not detected by the reftest. 
I've filed the bug #131064 to track this issue and will provide a patch soon.