Summary: | [CSS Blending] showLayerTree should dump layer's blend mode and isolation properties | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ion Rosca <rosca> | ||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, mihnea, simon.fraser, WebkitBugTracker | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 95614 | ||||||||||
Attachments: |
|
Description
Ion Rosca
2014-03-28 17:20:05 PDT
Created attachment 228100 [details]
adding blending debug values
Created attachment 228159 [details]
get blendMode from RenderLayer object
Comment on attachment 228159 [details] get blendMode from RenderLayer object View in context: https://bugs.webkit.org/attachment.cgi?id=228159&action=review You have to get Simon's or Dean's review on this but i will give you my opinion, hopefully it is valuable. > Source/WebCore/rendering/RenderLayer.h:789 > + BlendMode blendMode() const I think we should wrap everything in CSS_COMPOSITING unless it is really important to have functions that work also when CSS_COMPOSITING is not enabled. > Source/WebCore/rendering/RenderTreeAsText.cpp:631 > + if (l.hasBlendMode()) I would use ENABLE(CSS_COMPOSITING) to guard this code. In addition to that, i would simply output "isolatesBlending" instead of "isolation" when a layer does this. Created attachment 228183 [details]
#ifdef and isolation->isolatesBlending
Comment on attachment 228183 [details] #ifdef and isolation->isolatesBlending Clearing flags on attachment: 228183 Committed r166525: <http://trac.webkit.org/changeset/166525> All reviewed patches have been landed. Closing bug. |