Bug 130922

Summary: [CSS Blending] showLayerTree should dump layer's blend mode and isolation properties
Product: WebKit Reporter: Ion Rosca <rosca>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, mihnea, simon.fraser, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95614    
Attachments:
Description Flags
adding blending debug values
none
get blendMode from RenderLayer object
none
#ifdef and isolation->isolatesBlending none

Description Ion Rosca 2014-03-28 17:20:05 PDT
showLayerTree does not provide information regarding blending.
It would be useful to add blendMode property and layer's isolation status (if it isolates some blending descendants).
Comment 1 Ion Rosca 2014-03-28 17:30:54 PDT
Created attachment 228100 [details]
adding blending debug values
Comment 2 Ion Rosca 2014-03-31 02:26:14 PDT
Created attachment 228159 [details]
get blendMode from RenderLayer object
Comment 3 Mihnea Ovidenie 2014-03-31 08:14:24 PDT
Comment on attachment 228159 [details]
get blendMode from RenderLayer object

View in context: https://bugs.webkit.org/attachment.cgi?id=228159&action=review

You have to get Simon's or Dean's review on this but i will give you my opinion, hopefully it is valuable.

> Source/WebCore/rendering/RenderLayer.h:789
> +    BlendMode blendMode() const

I think we should wrap everything in CSS_COMPOSITING unless it is really important to have functions that work also when CSS_COMPOSITING is not enabled.

> Source/WebCore/rendering/RenderTreeAsText.cpp:631
> +    if (l.hasBlendMode())

I would use ENABLE(CSS_COMPOSITING) to guard this code. In addition to that, i would simply output "isolatesBlending" instead of "isolation" when a layer does this.
Comment 4 Ion Rosca 2014-03-31 10:34:39 PDT
Created attachment 228183 [details]
#ifdef and isolation->isolatesBlending
Comment 5 WebKit Commit Bot 2014-03-31 14:07:14 PDT
Comment on attachment 228183 [details]
#ifdef and isolation->isolatesBlending

Clearing flags on attachment: 228183

Committed r166525: <http://trac.webkit.org/changeset/166525>
Comment 6 WebKit Commit Bot 2014-03-31 14:07:19 PDT
All reviewed patches have been landed.  Closing bug.