Bug 130915

Summary: Radio buttons and checkboxes should share code
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, jonlee, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Beth Dakin
Reported 2014-03-28 16:14:31 PDT
Radio buttons and checkboxes should share code, and this will easily allow radio buttons to pick up the work for incremental redraw that was added with https://bugs.webkit.org/show_bug.cgi?id=130736 <rdar://problem/16175198>
Attachments
Patch (13.60 KB, patch)
2014-03-28 16:21 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-03-28 16:21:59 PDT
Created attachment 228089 [details] Patch
Anders Carlsson
Comment 2 2014-03-29 07:44:39 PDT
Comment on attachment 228089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228089&action=review > Source/WebCore/platform/mac/ThemeMac.mm:298 > +static const IntSize* radioSizes() I think you should make this return a const std::array<IntSize, 3>&
Beth Dakin
Comment 3 2014-03-31 11:11:50 PDT
Thanks, Sam! I will address Anders' suggestion in a follow-up patch. http://trac.webkit.org/changeset/166514
Note You need to log in before you can comment on or make changes to this bug.