Summary: | Radio buttons and checkboxes should share code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, dino, jonlee, simon.fraser, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Beth Dakin
2014-03-28 16:14:31 PDT
Created attachment 228089 [details]
Patch
Comment on attachment 228089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228089&action=review > Source/WebCore/platform/mac/ThemeMac.mm:298 > +static const IntSize* radioSizes() I think you should make this return a const std::array<IntSize, 3>& Thanks, Sam! I will address Anders' suggestion in a follow-up patch. http://trac.webkit.org/changeset/166514 |