Bug 130912

Summary:

Web Inspector: Really drop all locks in nested run loop on iOS if WebThread is enabled

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, mark.lam, mhahnenberg, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-03-28 15:36:34 PDT

On iOS we were not dropping all locks as we expected because of scoping. We should drop the JSLock if running the nested run loop on the WebThread. <rdar://problem/15835877>

Attachments
[PATCH] Proposed Fix (3.11 KB, patch) 2014-03-28 15:40 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-03-28 15:40:21 PDT

Created attachment 228087 [details] [PATCH] Proposed Fix

Geoffrey Garen

Comment 2 2014-03-28 15:56:21 PDT

Comment on attachment 228087 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2014-03-28 16:32:05 PDT

Comment on attachment 228087 [details] [PATCH] Proposed Fix Clearing flags on attachment: 228087 Committed r166436: <http://trac.webkit.org/changeset/166436>

WebKit Commit Bot

Comment 4 2014-03-28 16:32:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.