Bug 130912 - Web Inspector: Really drop all locks in nested run loop on iOS if WebThread is enabled
Summary: Web Inspector: Really drop all locks in nested run loop on iOS if WebThread i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-28 15:36 PDT by Joseph Pecoraro
Modified: 2014-03-28 16:32 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.11 KB, patch)
2014-03-28 15:40 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-03-28 15:36:34 PDT 
On iOS we were not dropping all locks as we expected because of scoping. We should drop the JSLock if running the nested run loop on the WebThread.

<rdar://problem/15835877>
Comment 1 Joseph Pecoraro 2014-03-28 15:40:21 PDT 
Created attachment 228087 [details]
[PATCH] Proposed Fix
Comment 2 Geoffrey Garen 2014-03-28 15:56:21 PDT 
Comment on attachment 228087 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2014-03-28 16:32:05 PDT 
Comment on attachment 228087 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 228087

Committed r166436: <http://trac.webkit.org/changeset/166436>
Comment 4 WebKit Commit Bot 2014-03-28 16:32:08 PDT 
All reviewed patches have been landed.  Closing bug.