Bug 130907

Summary: AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if roleValue is ApplicationAlertRole || ApplicationStatusRole
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: James Craig <jcraig>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Description James Craig 2014-03-28 11:59:45 PDT 
AX: AccessibilityObject::ariaLiveRegionAtomic() should default to true if roleValue() is ApplicationAlertRole || ApplicationStatusRole
Obviously an explicit @aria-atomic value of "false" should override the default.

http://www.w3.org/TR/wai-aria/complete#alert
http://www.w3.org/TR/wai-aria/complete#status
Comment 1 Radar WebKit Bug Importer 2014-03-28 12:00:17 PDT 
<rdar://problem/16459599>
Comment 2 James Craig 2014-03-30 00:30:12 PDT 
Created attachment 228122 [details]
patch
Comment 3 WebKit Commit Bot 2014-03-30 00:30:51 PDT 
Attachment 228122 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3099:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 James Craig 2014-03-30 00:32:44 PDT 
Created attachment 228123 [details]
patch
Comment 5 chris fleizach 2014-04-01 09:06:18 PDT 
Comment on attachment 228123 [details]
patch

looking good!
Comment 6 WebKit Commit Bot 2014-04-01 09:37:11 PDT 
Comment on attachment 228123 [details]
patch

Clearing flags on attachment: 228123

Committed r166594: <http://trac.webkit.org/changeset/166594>
Comment 7 WebKit Commit Bot 2014-04-01 09:37:14 PDT 
All reviewed patches have been landed.  Closing bug.