Bug 130887

Summary: REGRESSION(r166376): This was a misguided optimization. (Requested by kling on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130857    
Attachments:
Description Flags
ROLLOUT of r166376 none

Description WebKit Commit Bot 2014-03-27 22:21:45 PDT 
http://trac.webkit.org/changeset/166376 broke the build:
This was a misguided optimization. (Requested by kling on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2014-03-27 22:22:06 PDT 
Created attachment 228025 [details]
ROLLOUT of r166376

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2014-03-27 22:29:03 PDT 
Comment on attachment 228025 [details]
ROLLOUT of r166376

Clearing flags on attachment: 228025

Committed r166397: <http://trac.webkit.org/changeset/166397>
Comment 3 WebKit Commit Bot 2014-03-27 22:29:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Mark Hahnenberg 2014-03-28 06:59:35 PDT 
Why? I thought at least the change from structure -> newStructure in the second part of the patch made the code more readable.