Bug 130884

Summary:

[iOS][WK2] Adjust the tile coverage on the scrollview's edges

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2014-03-27 19:50:50 PDT

[iOS][WK2] Adjust the tile coverage on the scrollview's edges

Comment 1 Benjamin Poulain 2014-03-27 19:53:12 PDT

Created attachment 228020 [details]
Patch

Comment 2 mitz 2014-03-27 20:06:25 PDT

Comment on attachment 228020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228020&action=review

> Source/WebCore/platform/ios/ScrollViewIOS.mm:168
> +    IntSize contentSize = contentsSize();
> +    if (futureRect.maxX() > contentSize.width())
> +        futureRect.setX(contentSize.width() - futureRect.width());
> +    if (futureRect.maxY() > contentSize.height())
> +        futureRect.setY(contentSize.height() - futureRect.height());
> +    if (futureRect.x() < 0)
> +        futureRect.setX(0);
> +    if (futureRect.y() < 0)
> +        futureRect.setY(0);
> +

Can’t this be written more concisely as intersecting futureRect with the rect { FloatPoint(), contentSize() }?

Comment 3 Benjamin Poulain 2014-03-27 20:51:10 PDT

Comment on attachment 228020 [details]
Patch

Clearing flags on attachment: 228020

Committed r166394: <http://trac.webkit.org/changeset/166394>

Comment 4 Benjamin Poulain 2014-03-27 20:51:11 PDT

All reviewed patches have been landed.  Closing bug.