Bug 130882

Summary: Specify Shadow Pseudo Ids in Media Element Constructors
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, xacchriya341
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 131044    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2014-03-27 18:07:06 PDT
Several media elements, e.g., the MediaControlTextTrackContainerElement, are not initialized with their Shadow DOM Pseudo Id (e.g., the "-webkit-media-text-track-container") value. When the pseudoId is not set, the Web Inspector can be confusing, because the element only displays as a "<div>", with nothing showing it's functional purpose in the media control hierarchy. We should set the pseudo Id at construction time so that the object displays properly.
Attachments
Patch (12.31 KB, patch)
2014-03-27 18:13 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-03-27 18:13:56 PDT
Created attachment 228015 [details] Patch
Brent Fulgham
Comment 2 2014-03-27 20:19:48 PDT
It looks like inside WebCore itself, we call "shadowPseudoId()" to retrieve the value. However, the WebInspector and other pure JS clients call through the attribute access logic which only gets set up if a call to "setPseudo" is made at some point. It would probably be wise to coalesce these two "separate but equal" concepts of shadow ID.
WebKit Commit Bot
Comment 3 2014-03-27 20:52:28 PDT
Comment on attachment 228015 [details] Patch Clearing flags on attachment: 228015 Committed r166395: <http://trac.webkit.org/changeset/166395>
WebKit Commit Bot
Comment 4 2014-03-27 20:52:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.