Summary: | Specify Shadow Pseudo Ids in Media Element Constructors | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 131044 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Brent Fulgham
2014-03-27 18:07:06 PDT
Created attachment 228015 [details]
Patch
It looks like inside WebCore itself, we call "shadowPseudoId()" to retrieve the value. However, the WebInspector and other pure JS clients call through the attribute access logic which only gets set up if a call to "setPseudo" is made at some point. It would probably be wise to coalesce these two "separate but equal" concepts of shadow ID. Comment on attachment 228015 [details] Patch Clearing flags on attachment: 228015 Committed r166395: <http://trac.webkit.org/changeset/166395> All reviewed patches have been landed. Closing bug. |