|Summary:||A TrailingObject's endpoint might get decremented twice|
|Product:||WebKit||Reporter:||Myles C. Maxfield <mmaxfield>|
|Component:||New Bugs||Assignee:||Myles C. Maxfield <mmaxfield>|
|Severity:||Normal||CC:||commit-queue, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, simon.fraser, thorton, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description Myles C. Maxfield 2014-03-27 16:37:16 PDT
A TrailingObject's endpoint might get decremented twice
Comment 2 Myles C. Maxfield 2014-03-27 16:41:31 PDT
Comment on attachment 228006 [details] Patch This is probably the worse ChangeLog that I have ever written.
Comment 4 Tim Horton 2014-03-27 16:54:53 PDT
Comment on attachment 228007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review > Source/WebCore/ChangeLog:9 > + 1. When we have both an ending position and it's accompanying starting its :|
Comment 5 Myles C. Maxfield 2014-03-27 16:55:37 PDT
Comment on attachment 228007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review > Source/WebCore/ChangeLog:8 > + There are two places where we decrement a TrailingObject's ending position. There are more than two, but these are the two that I am interested in.
Comment 7 Darin Adler 2014-03-28 01:05:32 PDT
Comment on attachment 228007 [details] Patch Code change looks fine. Not sure what the point is of writing such a long change log. If this is really hard to understand, then I think we would need a comment instead of a change log entry. Next time you find you are writing a log this long, I suggest talking to another WebKit contributor in person. Together you can probably come up with a shorter explanation. I find that the process of talking through it out loud helps.