| Summary: | A TrailingObject's endpoint might get decremented twice | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2014-03-27 16:37:16 PDT
Created attachment 228006 [details]
Patch
Comment on attachment 228006 [details]
Patch
This is probably the worse ChangeLog that I have ever written.
Created attachment 228007 [details]
Patch
Comment on attachment 228007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review > Source/WebCore/ChangeLog:9 > + 1. When we have both an ending position and it's accompanying starting its :| Comment on attachment 228007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228007&action=review > Source/WebCore/ChangeLog:8 > + There are two places where we decrement a TrailingObject's ending position. There are more than two, but these are the two that I am interested in. Comment on attachment 228007 [details]
Patch
Code change looks fine. Not sure what the point is of writing such a long change log. If this is really hard to understand, then I think we would need a comment instead of a change log entry. Next time you find you are writing a log this long, I suggest talking to another WebKit contributor in person. Together you can probably come up with a shorter explanation. I find that the process of talking through it out loud helps.
|