Summary: | REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominoes) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
Component: | Layout and Rendering | Assignee: | Adele Peterson <adele> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | HasReduction, InRadar, Regression | ||||||
Priority: | P1 | ||||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
URL: | http://www.dominos.com | ||||||||
Attachments: |
|
Description
Beth Dakin
2007-03-15 13:19:23 PDT
Does this automatically cc me? I can never remember... (In reply to comment #2) > Does this automatically cc me? I can never remember... Yes, it should, but what email you get depends on your settings. (For example, if you don't care when people just add a Cc: address, you won't get email.) Created attachment 13654 [details]
reduction: self-closing input tag
Here is a reduction. Looks like we used to allow self-closing input tags but don't anymore. Firefox allows them too.
Thanks, Dave! I take that back. repros without self-closing as well. It's the name attribute. Adding a name attribute makes it work. Comment on attachment 13654 [details]
reduction: self-closing input tag
Okay, it turns out this reduction is not valid. Our behavior here matches IE, and we made the change intentionally. There is some other JavaScript at the site that makes the radio button still click in IE. I am working on another reduction.
Created attachment 13711 [details]
patch
We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior. Comment on attachment 13711 [details]
patch
yay! r=me!
Committed revision 20333. |