Bug 130860

Summary:

Check the remembered set bit faster

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Mark Hahnenberg

Reported 2014-03-27 14:33:54 PDT

Currently we look up the remembered set bit in the MarkedBlock in C++ code, but that bit is also stored in the object. We should look it up there whenever possible.

Attachments
Patch (4.43 KB, patch) 2014-03-27 14:42 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2014-03-27 14:42:09 PDT

Created attachment 227983 [details] Patch

Mark Hahnenberg

Comment 2 2014-03-27 14:44:16 PDT

(In reply to comment #1) > Created an attachment (id=227983) [details] > Patch This appears to be performance neutral on the benchmarks we track.

WebKit Commit Bot

Comment 3 2014-03-27 15:34:49 PDT

Comment on attachment 227983 [details] Patch Clearing flags on attachment: 227983 Committed r166375: <http://trac.webkit.org/changeset/166375>

WebKit Commit Bot

Comment 4 2014-03-27 15:34:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.