Bug 130860

Summary: Check the remembered set bit faster
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mark Hahnenberg 2014-03-27 14:33:54 PDT 
Currently we look up the remembered set bit in the MarkedBlock in C++ code, but that bit is also stored in the object. We should look it up there whenever possible.
Comment 1 Mark Hahnenberg 2014-03-27 14:42:09 PDT 
Created attachment 227983 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-27 14:44:16 PDT 
(In reply to comment #1)
> Created an attachment (id=227983) [details]
> Patch

This appears to be performance neutral on the benchmarks we track.
Comment 3 WebKit Commit Bot 2014-03-27 15:34:49 PDT 
Comment on attachment 227983 [details]
Patch

Clearing flags on attachment: 227983

Committed r166375: <http://trac.webkit.org/changeset/166375>
Comment 4 WebKit Commit Bot 2014-03-27 15:34:51 PDT 
All reviewed patches have been landed.  Closing bug.