Bug 130845

Summary: Clean up questionable style in ScriptExecutable::prepareForExecutionImpl
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Description Mark Hahnenberg 2014-03-27 10:07:59 PDT 
There was a hack added to make sure C Loop LLInt worked which included overriding the global Options::useLLInt setting, which makes no sense to do here. We should factor all of the crazy ifdefs into a separate shouldUseLLInt helper function and we should get rid of the global override.
Comment 1 Mark Hahnenberg 2014-03-27 10:12:53 PDT 
Created attachment 227954 [details]
patch
Comment 2 Mark Hahnenberg 2014-03-27 10:25:11 PDT 
Created attachment 227955 [details]
patch
Comment 3 WebKit Commit Bot 2014-03-27 12:19:55 PDT 
Comment on attachment 227955 [details]
patch

Clearing flags on attachment: 227955

Committed r166366: <http://trac.webkit.org/changeset/166366>
Comment 4 WebKit Commit Bot 2014-03-27 12:19:57 PDT 
All reviewed patches have been landed.  Closing bug.