Bug 130845

Summary: Clean up questionable style in ScriptExecutable::prepareForExecutionImpl
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Mark Hahnenberg
Reported 2014-03-27 10:07:59 PDT
There was a hack added to make sure C Loop LLInt worked which included overriding the global Options::useLLInt setting, which makes no sense to do here. We should factor all of the crazy ifdefs into a separate shouldUseLLInt helper function and we should get rid of the global override.
Attachments
patch (2.25 KB, patch)
2014-03-27 10:12 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
patch (2.48 KB, patch)
2014-03-27 10:25 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-27 10:12:53 PDT
Created attachment 227954 [details] patch
Mark Hahnenberg
Comment 2 2014-03-27 10:25:11 PDT
Created attachment 227955 [details] patch
WebKit Commit Bot
Comment 3 2014-03-27 12:19:55 PDT
Comment on attachment 227955 [details] patch Clearing flags on attachment: 227955 Committed r166366: <http://trac.webkit.org/changeset/166366>
WebKit Commit Bot
Comment 4 2014-03-27 12:19:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.