Bug 130835

Summary:

AX: Returns const reference to static string.

Product:

WebKit

Reporter:

Krzysztof Czech <k.czech>

Component:

Accessibility

Assignee:

Krzysztof Czech <k.czech>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, mario, philipj, samuel_white, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mario: review+, commit-queue: commit-queue-

Description Krzysztof Czech 2014-03-27 06:17:16 PDT

Avoiding unnecessary copies by returning const reference to static string.

Comment 1 Radar WebKit Bug Importer 2014-03-27 06:17:39 PDT

<rdar://problem/16443548>

Comment 2 Krzysztof Czech 2014-03-27 06:24:50 PDT

Created attachment 227942 [details]
patch

Comment 3 WebKit Commit Bot 2014-03-27 08:05:31 PDT

Comment on attachment 227942 [details]
patch

Rejecting attachment 227942 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227942, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/4872726934192128

Comment 4 Krzysztof Czech 2014-03-27 08:19:44 PDT

Committed r166358: <http://trac.webkit.org/changeset/166358>