Bug 130827 – Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds

• Component: Web Inspector
• Status: RESOLVED FIXED

[James Craig]

Web Inspector: AXI: expose selected children of list boxes, tree controls, etc.

[Radar WebKit Bug Importer]

<rdar://problem/16442393>

[James Craig]

Created attachment 228018 [details]
patch

[Timothy Hatcher]

Comment on attachment 228018 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228018&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1561
> +                for (const auto& selectedChildObject : selectedChildren) {

No need for const, IIRC.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:393
> +                    this._accessibilityNodeChildrenRow.label = WebInspector.UIString("Child");                

I'd say Children is fine for the singular case too. Just not if a count is part if the label.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:414
> +                    this._accessibilityNodeSelectedChildrenRow.label = WebInspector.UIString("Selected Item");                

Hmm. I think this is fine though.

[James Craig]

Created attachment 228024 [details]
patch with review feedback

[WebKit Commit Bot]

Comment on attachment 228024 [details]
patch with review feedback

Clearing flags on attachment: 228024

Committed r166398: <http://trac.webkit.org/changeset/166398>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.