Bug 130798

Summary: Device scale factor should always be greater than 0.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ddkilzer: review+

zalan
Reported 2014-03-26 14:15:14 PDT
Scale factor values in general can go 0 or even to negative, but device scale factor is about device pixel/CSS pixel ratio. It makes hardly any sense to have that as 0 or negative.
Attachments
Patch (1.37 KB, patch)
2014-03-26 15:33 PDT, zalan 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-03-26 15:33:48 PDT
Created attachment 227892 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2014-03-26 15:36:01 PDT
Comment on attachment 227892 [details] Patch r=me
zalan
Comment 3 2014-03-26 15:36:38 PDT
<rdar://problem/16293570>
zalan
Comment 4 2014-03-26 15:43:46 PDT
Committed r166323: <http://trac.webkit.org/changeset/166323>
Note You need to log in before you can comment on or make changes to this bug.