Bug 130798

Summary:

Device scale factor should always be greater than 0.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description zalan 2014-03-26 14:15:14 PDT

Scale factor values in general can go 0 or even to negative, but device scale factor is about device pixel/CSS pixel ratio. It makes hardly any sense to have that as 0 or negative.

Comment 1 zalan 2014-03-26 15:33:48 PDT

Created attachment 227892 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2014-03-26 15:36:01 PDT

Comment on attachment 227892 [details]
Patch

r=me

Comment 3 zalan 2014-03-26 15:36:38 PDT

<rdar://problem/16293570>

Comment 4 zalan 2014-03-26 15:43:46 PDT

Committed r166323: <http://trac.webkit.org/changeset/166323>