Bug 130798 - Device scale factor should always be greater than 0.
Summary: Device scale factor should always be greater than 0.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-26 14:15 PDT by zalan
Modified: 2014-03-26 15:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2014-03-26 15:33 PDT, zalan 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-03-26 14:15:14 PDT 
Scale factor values in general can go 0 or even to negative, but device scale factor is about device pixel/CSS pixel ratio. It makes hardly any sense to have that as 0 or negative.
Comment 1 zalan 2014-03-26 15:33:48 PDT 
Created attachment 227892 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2014-03-26 15:36:01 PDT 
Comment on attachment 227892 [details]
Patch

r=me
Comment 3 zalan 2014-03-26 15:36:38 PDT 
<rdar://problem/16293570>
Comment 4 zalan 2014-03-26 15:43:46 PDT 
Committed r166323: <http://trac.webkit.org/changeset/166323>