| Summary: | Add a new type of scrolling tree node for overflow scrolling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, bdakin, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, sam, simon.fraser, thorton, tonikitoo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2014-03-25 19:44:39 PDT
Created attachment 227827 [details]
Patch
Comment on attachment 227827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227827&action=review > Source/WebCore/page/scrolling/ScrollingStateNode.h:155 > + bool isFixedNode() const { return nodeType() == FixedNode; } why do these use nodeType() instead of m_nodeType? (not that it matters) > Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:151 > + case OverflowScrollingNode: // Not yet created on Mac. Maybe this could be better documented with an ASSERT_NOT_REACHED() and return null? That will be easier to find when we implement scrolling-tree-overflow-scroll on Mac. |