Bug 130725 – Web Inspector: AXI: support for live regions

• Component: Web Inspector
• Status: RESOLVED FIXED

[James Craig]

# Live Region Attrs (only when a live region)
- live (assertive, polite, off)
- relevance (additions, removals, etc)
- atomic

Especially useful b/c some roles (status, log, alert) get aria-live values by default. @aria-atomic and @aria-relevant is not always apparent on the current node either, if there is some depth to the live region.

[Radar WebKit Bug Importer]

<rdar://problem/16420300>

[James Craig]

AccessibilityObject::supportsARIALiveRegion()
AccessibilityObject::isInsideARIALiveRegion()

[James Craig]

AccessibilityObject.h

    bool supportsARIALiveRegion() const;
    bool isInsideARIALiveRegion() const;
    virtual const AtomicString& ariaLiveRegionStatus() const { return nullAtom; }
    virtual const AtomicString& ariaLiveRegionRelevant() const { return nullAtom; }
    virtual bool ariaLiveRegionAtomic() const { return false; }
    virtual bool ariaLiveRegionBusy() const { return false; }

[James Craig]

Done with most of this except:

Bug 130913: Web Inspector: AXI: expose aria-relevant
Bug 130918: Web Inspector: AXI: expose if current node is inside an ancestor live region

[James Craig]

Created attachment 228103 [details]
patch

[Timothy Hatcher]

Comment on attachment 228103 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228103&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:366
> +                if (liveRegionStatusToken === DOMAgent.AccessibilityPropertiesLiveRegionStatus.Assertive)

This could be a switch with cases.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:370
> +                if (liveRegionStatus !== "" && accessibilityProperties.liveRegionAtomic === true) {

No need for !== "".

[James Craig]

Created attachment 228104 [details]
patch with review feedback

[James Craig]

Created attachment 228105 [details]
patch with review feedback (and test expectation update)

[WebKit Commit Bot]

Comment on attachment 228105 [details]
patch with review feedback (and test expectation update)

Clearing flags on attachment: 228105

Committed r166449: <http://trac.webkit.org/changeset/166449>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.