Bug 130718

Summary: [Mac] Pause the media element during system sleep.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, philipj, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch for landing commit-queue: commit-queue-

Jer Noble
Reported 2014-03-25 08:41:27 PDT
'[Mac] Pause the media element during system sleep.'
Attachments
Patch (27.82 KB, patch)
2014-03-25 09:16 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (27.40 KB, patch)
2014-03-25 11:28 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (28.55 KB, patch)
2014-03-25 12:58 PDT, Jer Noble 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-03-25 09:16:08 PDT
Created attachment 227756 [details] Patch
Jer Noble
Comment 2 2014-03-25 11:28:11 PDT
Created attachment 227774 [details] Patch
Eric Carlson
Comment 3 2014-03-25 11:38:30 PDT
Comment on attachment 227774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227774&action=review > Source/WebCore/ChangeLog:13 > + system sleep, explicitly pause the media before sleeping and resum (if Nit: missing an "e" : resum
Jer Noble
Comment 4 2014-03-25 12:58:19 PDT
Created attachment 227783 [details] Patch for landing
WebKit Commit Bot
Comment 5 2014-03-25 13:34:03 PDT
Comment on attachment 227783 [details] Patch for landing Rejecting attachment 227783 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227783, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5429122230648832
Jer Noble
Comment 6 2014-03-25 15:27:19 PDT
Committed r166261: <http://trac.webkit.org/changeset/166261>
Note You need to log in before you can comment on or make changes to this bug.