Bug 130718

Summary: [Mac] Pause the media element during system sleep.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, philipj, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch for landing commit-queue: commit-queue-

Description Jer Noble 2014-03-25 08:41:27 PDT 
'[Mac] Pause the media element during system sleep.'
Comment 1 Jer Noble 2014-03-25 09:16:08 PDT 
Created attachment 227756 [details]
Patch
Comment 2 Jer Noble 2014-03-25 11:28:11 PDT 
Created attachment 227774 [details]
Patch
Comment 3 Eric Carlson 2014-03-25 11:38:30 PDT 
Comment on attachment 227774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227774&action=review

> Source/WebCore/ChangeLog:13
> +        system sleep, explicitly pause the media before sleeping and resum (if

Nit: missing an "e" : resum
Comment 4 Jer Noble 2014-03-25 12:58:19 PDT 
Created attachment 227783 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-03-25 13:34:03 PDT 
Comment on attachment 227783 [details]
Patch for landing

Rejecting attachment 227783 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227783, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5429122230648832
Comment 6 Jer Noble 2014-03-25 15:27:19 PDT 
Committed r166261: <http://trac.webkit.org/changeset/166261>