Bug 130718 - [Mac] Pause the media element during system sleep.
Summary: [Mac] Pause the media element during system sleep.
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Depends on:
Reported: 2014-03-25 08:41 PDT by Jer Noble
Modified: 2014-03-25 15:27 PDT (History)
10 users (show)

See Also:

Patch (27.82 KB, patch)
2014-03-25 09:16 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (27.40 KB, patch)
2014-03-25 11:28 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (28.55 KB, patch)
2014-03-25 12:58 PDT, Jer Noble
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-03-25 08:41:27 PDT
'[Mac] Pause the media element during system sleep.'
Comment 1 Jer Noble 2014-03-25 09:16:08 PDT
Created attachment 227756 [details]
Comment 2 Jer Noble 2014-03-25 11:28:11 PDT
Created attachment 227774 [details]
Comment 3 Eric Carlson 2014-03-25 11:38:30 PDT
Comment on attachment 227774 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=227774&action=review

> Source/WebCore/ChangeLog:13
> +        system sleep, explicitly pause the media before sleeping and resum (if

Nit: missing an "e" : resum
Comment 4 Jer Noble 2014-03-25 12:58:19 PDT
Created attachment 227783 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-03-25 13:34:03 PDT
Comment on attachment 227783 [details]
Patch for landing

Rejecting attachment 227783 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227783, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5429122230648832
Comment 6 Jer Noble 2014-03-25 15:27:19 PDT
Committed r166261: <http://trac.webkit.org/changeset/166261>