Bug 130700

Summary: Enable WEB_REPLAY for PLATFORM(MAC)
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebCore Misc.Assignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, darin, dbates, ddkilzer, joepeck, kling, sam, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip - needs inspector UI toggle
none
the patch timothy: review+

Description BJ Burg 2014-03-24 16:21:19 PDT 
We would like to compile with this feature turned on for nightlies. Replay controls will be hidden behind a setting or key combination in the inspector UI until the temporary replay UI is replaced.
Comment 1 Brian Burg 2014-04-04 19:35:29 PDT 
Created attachment 228647 [details]
wip - needs inspector UI toggle
Comment 2 Timothy Hatcher 2014-04-04 20:36:06 PDT 
Comment on attachment 228647 [details]
wip - needs inspector UI toggle

Looking good so far.
Comment 3 Brian Burg 2014-04-05 23:12:44 PDT 
Created attachment 228694 [details]
the patch
Comment 4 Timothy Hatcher 2014-04-06 09:34:01 PDT 
Comment on attachment 228694 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228694&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:401
> +            contextMenu.appendItem(WebInspector.UIString("Hide replay controls"), toggleReplayInterface);

Menu titles are Title Case.

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:403
> +            contextMenu.appendItem(WebInspector.UIString("Show replay controls"), toggleReplayInterface);

Ditto.
Comment 5 Brian Burg 2014-04-06 10:28:44 PDT 
Committed r166851: <http://trac.webkit.org/changeset/166851>
Comment 6 Brian Burg 2014-04-06 10:29:38 PDT 
(In reply to comment #4)
> (From update of attachment 228694 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228694&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:401
> > +            contextMenu.appendItem(WebInspector.UIString("Hide replay controls"), toggleReplayInterface);
> 
> Menu titles are Title Case.
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:403
> > +            contextMenu.appendItem(WebInspector.UIString("Show replay controls"), toggleReplayInterface);
> 
> Ditto.

Fixed.