Bug 130700

Summary: Enable WEB_REPLAY for PLATFORM(MAC)
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebCore Misc.Assignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, darin, dbates, ddkilzer, joepeck, kling, sam, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip - needs inspector UI toggle
none
the patch timothy: review+

Blaze Burg
Reported 2014-03-24 16:21:19 PDT
We would like to compile with this feature turned on for nightlies. Replay controls will be hidden behind a setting or key combination in the inspector UI until the temporary replay UI is replaced.
Attachments
wip - needs inspector UI toggle (8.75 KB, patch)
2014-04-04 19:35 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
the patch (17.87 KB, patch)
2014-04-05 23:12 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-04-04 19:35:29 PDT
Created attachment 228647 [details] wip - needs inspector UI toggle
Timothy Hatcher
Comment 2 2014-04-04 20:36:06 PDT
Comment on attachment 228647 [details] wip - needs inspector UI toggle Looking good so far.
Brian Burg
Comment 3 2014-04-05 23:12:44 PDT
Created attachment 228694 [details] the patch
Timothy Hatcher
Comment 4 2014-04-06 09:34:01 PDT
Comment on attachment 228694 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228694&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:401 > + contextMenu.appendItem(WebInspector.UIString("Hide replay controls"), toggleReplayInterface); Menu titles are Title Case. > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:403 > + contextMenu.appendItem(WebInspector.UIString("Show replay controls"), toggleReplayInterface); Ditto.
Brian Burg
Comment 5 2014-04-06 10:28:44 PDT
Committed r166851: <http://trac.webkit.org/changeset/166851>
Brian Burg
Comment 6 2014-04-06 10:29:38 PDT
(In reply to comment #4) > (From update of attachment 228694 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228694&action=review > > > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:401 > > + contextMenu.appendItem(WebInspector.UIString("Hide replay controls"), toggleReplayInterface); > > Menu titles are Title Case. > > > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:403 > > + contextMenu.appendItem(WebInspector.UIString("Show replay controls"), toggleReplayInterface); > > Ditto. Fixed.
Note You need to log in before you can comment on or make changes to this bug.