Bug 130698

Summary: [CSS Shapes] Remove shape-inside support
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: CSSAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, betravis, bjonesbe, bunhere, commit-queue, dbates, dino, dstockwell, esprehn+autocc, giles_joplin, glenn, gyuyoung.kim, jfernandez, kondapallykalyan, macpherson, menard, rakuco, rego, rwlbuis, sergio, simon.fraser, svillar, syoichi, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 131641    
Bug Blocks: 89256, 127982, 130740, 130790    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
hyatt: review+
Patch
none
Patch for landing none

Description Zoltan Horvath 2014-03-24 15:28:19 PDT 
CSS Shapes Level 1 (CR) only contains shape-outside. We are focusing our efforts on finalizing the implementation of shape-outside, it's worth to remove shape-inside code at this point for now.

A list of reasons for the removal:
- Shape-inside is only part of Shapes Level 2, which needs to be improved on some topics.
- Shape-inside is lack of new shapes support (e.g. inset).
- Deprecated shapes (r165472) are removed from the code (e.g. rectangle), which affects shape-inside. 
- The current shape-inside code spreads across the layout code.
- The current shape-inside implementation is experimental in some areas, and the partially implemented code can have security implications.
- Removal of shape-inside opens possibilities for code complexity and performance optimizations for shape-outside. (e.g. simpler geometry code)

If there is no objections, I'll remove the code for now, so we can start working on the mentioned optimizations. I'll also close the bugs in bugzilla which are affected by the change.
Comment 1 Zoltan Horvath 2014-03-24 15:38:05 PDT 
Created attachment 227695 [details]
Patch
Comment 2 Zoltan Horvath 2014-03-24 16:34:13 PDT 
Created attachment 227702 [details]
Patch
Comment 3 Zoltan Horvath 2014-03-24 16:50:26 PDT 
Created attachment 227705 [details]
Patch
Comment 4 Zoltan Horvath 2014-03-24 18:03:29 PDT 
Once it is reviewed, I'll send out a mail to webkit-dev and wait 24hrs before landing.
Comment 5 Dave Hyatt 2014-03-25 10:19:57 PDT 
Comment on attachment 227705 [details]
Patch

r=me
Comment 6 Zoltan Horvath 2014-03-26 08:46:27 PDT 
Created attachment 227850 [details]
Patch
Comment 7 Zoltan Horvath 2014-03-26 10:40:30 PDT 
Created attachment 227863 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2014-03-26 11:20:45 PDT 
Comment on attachment 227863 [details]
Patch for landing

Clearing flags on attachment: 227863

Committed r166301: <http://trac.webkit.org/changeset/166301>
Comment 9 WebKit Commit Bot 2014-03-26 11:20:54 PDT 
All reviewed patches have been landed.  Closing bug.