Bug 130698

Summary:

[CSS Shapes] Remove shape-inside support

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

CSS

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, betravis, bjonesbe, bunhere, commit-queue, dbates, dino, dstockwell, esprehn+autocc, giles_joplin, glenn, gyuyoung.kim, jfernandez, kondapallykalyan, macpherson, menard, rakuco, rego, rwlbuis, sergio, simon.fraser, svillar, syoichi, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

131641

Bug Blocks:

89256, 127982, 130740, 130790

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	hyatt: review+
Patch	none
Patch for landing	none

Zoltan Horvath

Reported 2014-03-24 15:28:19 PDT

CSS Shapes Level 1 (CR) only contains shape-outside. We are focusing our efforts on finalizing the implementation of shape-outside, it's worth to remove shape-inside code at this point for now. A list of reasons for the removal: - Shape-inside is only part of Shapes Level 2, which needs to be improved on some topics. - Shape-inside is lack of new shapes support (e.g. inset). - Deprecated shapes (r165472) are removed from the code (e.g. rectangle), which affects shape-inside. - The current shape-inside code spreads across the layout code. - The current shape-inside implementation is experimental in some areas, and the partially implemented code can have security implications. - Removal of shape-inside opens possibilities for code complexity and performance optimizations for shape-outside. (e.g. simpler geometry code) If there is no objections, I'll remove the code for now, so we can start working on the mentioned optimizations. I'll also close the bugs in bugzilla which are affected by the change.

Attachments
Patch (561.17 KB, patch) 2014-03-24 15:38 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Patch (563.75 KB, patch) 2014-03-24 16:34 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Patch (563.91 KB, patch) 2014-03-24 16:50 PDT, Zoltan Horvath	hyatt: review+	Details Formatted Diff Diff
Patch (563.29 KB, patch) 2014-03-26 08:46 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Patch for landing (563.27 KB, patch) 2014-03-26 10:40 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.