Bug 130688

Summary: Add support for thread/WorkQueue QoS
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: Web Template FrameworkAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, bunhere, cdumez, cmarcelo, commit-queue, gyuyoung.kim, jamesr, luiz, sergio, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix
kling: review+
Fix andersca: review+

Gavin Barraclough
Reported 2014-03-24 11:30:32 PDT
.
Attachments
Fix (5.58 KB, patch)
2014-03-24 11:33 PDT, Gavin Barraclough 		kling: review+
DetailsFormatted DiffDiff
Fix (9.73 KB, patch)
2014-06-12 18:04 PDT, Gavin Barraclough 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-03-24 11:33:59 PDT
Created attachment 227670 [details] Fix
Andreas Kling
Comment 2 2014-03-24 12:03:37 PDT
Comment on attachment 227670 [details] Fix r=me
Gavin Barraclough
Comment 3 2014-03-24 12:26:02 PDT
Transmitting file data ....... Committed revision 166184.
Gavin Barraclough
Comment 4 2014-03-24 12:32:11 PDT
Speculative EFL build fix in: Transmitting file data .. Committed revision 166185.
Gavin Barraclough
Comment 5 2014-06-12 18:03:31 PDT
Previous fix rolled out.
Gavin Barraclough
Comment 6 2014-06-12 18:04:37 PDT
Created attachment 233012 [details] Fix
Anders Carlsson
Comment 7 2014-06-12 18:14:29 PDT
Comment on attachment 233012 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review > Source/WebKit2/Platform/mac/WorkQueueMac.cpp:48 > +static dispatch_qos_class_t platformQOS(WorkQueue::QOS qos) I'd call this dispatchQOSClass instead. > Source/WebKit2/Platform/mac/WorkQueueMac.cpp:60 > + default: > + return QOS_CLASS_DEFAULT; Please move this return out of the switch statement and add an ASSERT_NOT_REACHED() before it.
Simon Fraser (smfr)
Comment 8 2014-06-12 18:19:17 PDT
Comment on attachment 233012 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review > Source/WTF/wtf/Threading.cpp:91 > +#if (TARGET_OS_MAC && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000) > + pthread_set_qos_class_self_np(QOS_CLASS_USER_INTERACTIVE, 0); > +#endif Use HAVE_QOS_CLASSES > Source/WebKit2/config.h:99 > +#ifndef HAVE_QOS_CLASSES > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 > +#define HAVE_QOS_CLASSES 1 > +#endif > +#endif Move to Platform.h
Gavin Barraclough
Comment 9 2014-06-12 19:30:44 PDT
Fixed in r169926.
Note You need to log in before you can comment on or make changes to this bug.