Summary: | Add support for thread/WorkQueue QoS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||
Component: | Web Template Framework | Assignee: | Gavin Barraclough <barraclough> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, benjamin, bunhere, cdumez, cmarcelo, commit-queue, gyuyoung.kim, jamesr, luiz, sergio, tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gavin Barraclough
2014-03-24 11:30:32 PDT
Created attachment 227670 [details]
Fix
Comment on attachment 227670 [details]
Fix
r=me
Transmitting file data ....... Committed revision 166184. Speculative EFL build fix in: Transmitting file data .. Committed revision 166185. Previous fix rolled out. Created attachment 233012 [details]
Fix
Comment on attachment 233012 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review > Source/WebKit2/Platform/mac/WorkQueueMac.cpp:48 > +static dispatch_qos_class_t platformQOS(WorkQueue::QOS qos) I'd call this dispatchQOSClass instead. > Source/WebKit2/Platform/mac/WorkQueueMac.cpp:60 > + default: > + return QOS_CLASS_DEFAULT; Please move this return out of the switch statement and add an ASSERT_NOT_REACHED() before it. Comment on attachment 233012 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=233012&action=review > Source/WTF/wtf/Threading.cpp:91 > +#if (TARGET_OS_MAC && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000) > + pthread_set_qos_class_self_np(QOS_CLASS_USER_INTERACTIVE, 0); > +#endif Use HAVE_QOS_CLASSES > Source/WebKit2/config.h:99 > +#ifndef HAVE_QOS_CLASSES > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 > +#define HAVE_QOS_CLASSES 1 > +#endif > +#endif Move to Platform.h |