Summary: | fix prepare-ChangeLog after r166156. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | László Langó <llango.u-szeged> | ||||
Component: | Tools / Tests | Assignee: | László Langó <llango.u-szeged> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, gyuyoung.kim, ossy, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
László Langó
2014-03-24 09:12:12 PDT
Created attachment 227653 [details]
Patch
Comment on attachment 227653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227653&action=review > Tools/Scripts/prepare-ChangeLog:1977 > - $end = $3 || $1; > + if($4 gt "a") { > + $end = $3 || $1; > + } Missing space before "(". But since this is perl you could write: $end = $3 || $1 if $4 ne "a"; I think “ne” would be better than “gt”. Comment on attachment 227653 [details] Patch Clearing flags on attachment: 227653 Committed r166189: <http://trac.webkit.org/changeset/166189> All reviewed patches have been landed. Closing bug. |