Summary: | Simplify the HTMLConverter interface | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sam Weinig
2014-03-23 13:09:19 PDT
Created attachment 227615 [details]
Part 1
Comment on attachment 227615 [details] Part 1 View in context: https://bugs.webkit.org/attachment.cgi?id=227615&action=review > Source/WebCore/platform/mac/HTMLConverter.h:83 > ++ (NSAttributedString *)attributedStringFromRange:(WebCore::Range*)range; Why not make the argument a reference? (In reply to comment #2) > (From update of attachment 227615 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227615&action=review > > > Source/WebCore/platform/mac/HTMLConverter.h:83 > > ++ (NSAttributedString *)attributedStringFromRange:(WebCore::Range*)range; > > Why not make the argument a reference? I'll see about doing that in a bit. Committed r166143: <http://trac.webkit.org/changeset/166143> Created attachment 227617 [details]
Part 2
Comment on attachment 227617 [details] Part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=227617&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:6667 > + attributedString = [[[NSAttributedString alloc] init] autorelease]; I think you can just write [NSAttributedString string] for this. Committed r166145: <http://trac.webkit.org/changeset/166145> |