| Summary: | WebKit::resistanceForDelta() truncates 'scaleDistance' to integer value using abs() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 227608 [details]
Patch v1
Comment on attachment 227608 [details] Patch v1 Clearing flags on attachment: 227608 Committed r166140: <http://trac.webkit.org/changeset/166140> All reviewed patches have been landed. Closing bug. Yikes! Thanks for fixing. |
Compiling WebKit with trunk clang causes this warning: Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:112:28: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value] double scaleDistance = abs(limit - currentScale); ^ Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:112:28: note: use function 'fabs' instead double scaleDistance = abs(limit - currentScale); ^~~ fabs 1 error generated.