| Summary: | Clean up #includes by geometry classes | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
| Severity: | Normal | CC: | bunhere, cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan, luiz, macpherson, menard, noam, rakuco, sam, sergio, simon.fraser, zeno | ||||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Simon Fraser (smfr)
2014-03-22 13:09:54 PDT
Created attachment 227566 [details]
Patch
Comment on attachment 227566 [details]
Patch
Great! r=me if it builds :)
Comment on attachment 227566 [details] Patch Rejecting attachment 227566 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityMockObject.o accessibility/AccessibilityMockObject.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilitySpinButton.o accessibility/AccessibilitySpinButton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (7 failures) Full output: http://webkit-queues.appspot.com/results/6569124461281280 Created attachment 227571 [details]
For EWS
Created attachment 227579 [details]
For EWS
Created attachment 227582 [details]
For EWS
Created attachment 227588 [details]
For EWS again
Created attachment 227589 [details]
Will it never end?
Created attachment 227591 [details]
Apparently not
Created attachment 227593 [details]
Sigh
Created attachment 227594 [details]
Trying again
Created attachment 227597 [details]
Yep
Created attachment 227603 [details]
We love you EFL
Created attachment 227606 [details]
We love you EFL even more
Comment on attachment 227606 [details]
We love you EFL even more
Sending her off to landing.
Comment on attachment 227606 [details] We love you EFL even more Clearing flags on attachment: 227606 Committed r166138: <http://trac.webkit.org/changeset/166138> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/166139 is what I get by doing this before coffee. |