Bug 130645

Summary:

Clean up #includes by geometry classes

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, kondapallykalyan, luiz, macpherson, menard, noam, rakuco, sam, sergio, simon.fraser, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
For EWS	none
For EWS	none
For EWS	none
For EWS again	none
Will it never end?	none
Apparently not	none
Sigh	none
Trying again	none
Yep	none
We love you EFL	none
We love you EFL even more	none

Simon Fraser (smfr)

Reported 2014-03-22 13:09:54 PDT

Clean up #includes by geometry classes

Attachments
Patch (26.85 KB, patch) 2014-03-22 13:11 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS (21.32 KB, patch) 2014-03-22 14:14 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS (27.61 KB, patch) 2014-03-22 16:55 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS (28.02 KB, patch) 2014-03-22 17:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
For EWS again (28.52 KB, patch) 2014-03-22 17:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Will it never end? (28.99 KB, patch) 2014-03-22 18:14 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Apparently not (29.46 KB, patch) 2014-03-22 18:29 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Sigh (29.89 KB, patch) 2014-03-22 18:39 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Trying again (30.93 KB, patch) 2014-03-22 19:07 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Yep (33.19 KB, patch) 2014-03-22 20:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
We love you EFL (33.76 KB, patch) 2014-03-22 22:31 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
We love you EFL even more (34.34 KB, patch) 2014-03-22 23:51 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2014-03-22 13:11:59 PDT

Created attachment 227566 [details] Patch

Andreas Kling

Comment 2 2014-03-22 13:15:33 PDT

Comment on attachment 227566 [details] Patch Great! r=me if it builds :)

WebKit Commit Bot

Comment 3 2014-03-22 13:48:22 PDT

Comment on attachment 227566 [details] Patch Rejecting attachment 227566 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityMockObject.o accessibility/AccessibilityMockObject.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilitySpinButton.o accessibility/AccessibilitySpinButton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (7 failures) Full output: http://webkit-queues.appspot.com/results/6569124461281280

Simon Fraser (smfr)

Comment 4 2014-03-22 14:14:53 PDT

Created attachment 227571 [details] For EWS

Simon Fraser (smfr)

Comment 5 2014-03-22 16:55:26 PDT

Created attachment 227579 [details] For EWS

Simon Fraser (smfr)

Comment 6 2014-03-22 17:10:57 PDT

Created attachment 227582 [details] For EWS

Simon Fraser (smfr)

Comment 7 2014-03-22 17:58:27 PDT

Created attachment 227588 [details] For EWS again