Bug 130644

Summary: Call linking slow paths should be passed a CallLinkInfo* directly so that you can create a call IC without adding it to any CodeBlocks
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, ossy, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 130670    
Bug Blocks: 129589    
Attachments:
Description Flags
less than half way there
none
it builds on 64-bit
none
starting to work on 64-bit x86
none
the patch kling: review+

Description Filip Pizlo 2014-03-22 13:00:56 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-03-22 13:01:43 PDT 
Created attachment 227564 [details]
less than half way there
Comment 2 Filip Pizlo 2014-03-22 14:35:24 PDT 
Created attachment 227574 [details]
it builds on 64-bit

It even appears to pass testapi, but I'm sure it has many, many bugs.
Comment 3 Filip Pizlo 2014-03-22 15:45:56 PDT 
Created attachment 227576 [details]
starting to work on 64-bit x86
Comment 4 Filip Pizlo 2014-03-22 20:06:05 PDT 
Created attachment 227595 [details]
the patch
Comment 5 Andreas Kling 2014-03-22 21:26:19 PDT 
Comment on attachment 227595 [details]
the patch

r=me

I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;)
Comment 6 Filip Pizlo 2014-03-22 21:35:10 PDT 
(In reply to comment #5)
> (From update of attachment 227595 [details])
> r=me
> 
> I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;)

I did it!
Comment 7 Filip Pizlo 2014-03-22 21:35:34 PDT 
Landed in http://trac.webkit.org/changeset/166135
Comment 8 Simon Fraser (smfr) 2014-03-23 09:49:54 PDT 
This broke the CLOOP build.
Comment 9 Csaba Osztrogonác 2014-03-24 08:30:11 PDT 
(In reply to comment #8)
> This broke the CLOOP build.

new bug report for fixing the build: https://bugs.webkit.org/show_bug.cgi?id=130670