| Summary: | [WK2] Make updates on ViewUpdateDispatcher less heavy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-03-21 18:10:19 PDT
Created attachment 227520 [details]
Patch
Comment on attachment 227520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review > Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74 > localCopy.swap(m_latestUpdate); This should really use std::move instead of swap. Swap was the hack for doing this before we had move assignment. Also, the code below uses the word “iterator” strangely. It should be written like this: for (uint64_t pageID : localCopy.keys()) Comment on attachment 227520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227520&action=review >> Source/WebKit2/WebProcess/WebPage/ViewUpdateDispatcher.cpp:74 >> localCopy.swap(m_latestUpdate); > > This should really use std::move instead of swap. Swap was the hack for doing this before we had move assignment. > > Also, the code below uses the word “iterator” strangely. It should be written like this: > > for (uint64_t pageID : localCopy.keys()) Oops, that was wrong. Obviously we want both keys and values. I just don’t think that “iterator” is the right name for an entry in a HashMap. I suggest the name "slot". Committed r166191: <http://trac.webkit.org/changeset/166191> |