Bug 130614

Summary: Refactoring the BytecodeGenerator to use a BytecodeGeneratorVector.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED INVALID    
Severity: Normal CC: ggaren, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. mark.lam: review-

Mark Lam
Reported 2014-03-21 13:41:02 PDT
Introducing a BytecodeGeneratorVector for the purpose of pointing out the way the BytecodeGenerator uses element in those vectors i.e. it can retain references to elements in the vector while new elements are added, or some elements are removed. The BytecodeGeneratorVector is implemented as a SegmentedVector. The BytecodeGenerator will now use the BytecodeGeneratorVector instead of the SegmentedVector.
Attachments
the patch. (3.03 KB, patch)
2014-03-21 13:46 PDT, Mark Lam 		mark.lam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-03-21 13:46:09 PDT
Created attachment 227485 [details] the patch.
Mark Lam
Comment 2 2014-03-21 13:54:41 PDT
Fil pointed out that the use of SegmentedVector already adequately indicate the information about how the BytecodeGenerator uses those vector elements. At this point, there's no added benefit to doing this. So, I'll retract the patch.
Note You need to log in before you can comment on or make changes to this bug.