Summary: | [GTK] Add support for GTK3 plugins | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, rakuco, sergio, svillar | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-03-21 09:25:56 PDT
Created attachment 227446 [details]
Patch
$ ls -lh bin/WebKitPluginProcess*
-rwxr-xr-x 1 cgarcia cgarcia 7,4K mar 21 17:05 bin/WebKitPluginProcess
-rwxr-xr-x 1 cgarcia cgarcia 43M mar 21 17:05 bin/WebKitPluginProcess2
Comment on attachment 227446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227446&action=review > Source/WebKit2/PlatformGTK.cmake:524 > + set(PluginProcess2_EXECUTABLE_NAME WebKitPluginProcess2) > + list(APPEND PluginProcess2_INCLUDE_DIRECTORIES We use WebCorePlatformGTK2, so I think this should be PluginProcessGTK2 to maintain consistency. > Source/WebKit2/PlatformGTK.cmake:630 > - list(APPEND PluginProcess_MESSAGES_IN_FILES > + list(APPEND PluginProcess2_MESSAGES_IN_FILES > PluginProcess/PluginControllerProxy.messages.in > PluginProcess/PluginProcess.messages.in > PluginProcess/WebProcessConnection.messages.in > > Shared/Plugins/NPObjectMessageReceiver.messages.in > ) > - GENERATE_WEBKIT2_MESSAGE_SOURCES(PluginProcess_SOURCES "${PluginProcess_MESSAGES_IN_FILES}") > + GENERATE_WEBKIT2_MESSAGE_SOURCES(PluginProcess2_SOURCES "${PluginProcess2_MESSAGES_IN_FILES}") These files are generated in the shared CMakeLists.txt file now, so I think we can just remove these lines. Committed r166492: <http://trac.webkit.org/changeset/166492> |