Bug 130589

Summary: [webkitpy] Fix has_valid_reviewer()
Product: WebKit Reporter: Éva Balázsfalvi <evab.u-szeged>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, evab.u-szeged, glenn, ossy, rgabor
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Éva Balázsfalvi
Reported 2014-03-21 06:42:18 PDT
has_valid_reviewer() in Tools/Scripts/webkitpy/common/checkout/changelog.py returns with true for committers too, not only for reviewers
Attachments
Patch (3.82 KB, patch)
2014-03-21 06:46 PDT, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2014-03-21 06:46:02 PDT
Created attachment 227427 [details] Patch
Csaba Osztrogonác
Comment 2 2014-03-21 07:04:02 PDT
It's so ugly bug. :) The patch looks good to me. Gábor do you permit us to use your name in the unittest? Unfortunately this test should be updated once you become a reviewer. ;)
Gabor Rapcsanyi
Comment 3 2014-03-21 07:11:05 PDT
(In reply to comment #2) > It's so ugly bug. :) The patch looks good to me. Gábor do you permit > us to use your name in the unittest? Unfortunately this test should > be updated once you become a reviewer. ;) Of course, I'm honored :)
Csaba Osztrogonác
Comment 4 2014-03-21 07:17:14 PDT
Comment on attachment 227427 [details] Patch OK, r=me
WebKit Commit Bot
Comment 5 2014-03-21 07:50:02 PDT
Comment on attachment 227427 [details] Patch Clearing flags on attachment: 227427 Committed r166062: <http://trac.webkit.org/changeset/166062>
WebKit Commit Bot
Comment 6 2014-03-21 07:50:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.