Bug 130567

Summary: [EFL][WK2] Remove Ewk_Error parameter from some async callbacks
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2014-03-21 00:07:37 PDT 
WebKit2 internally use GenericCallbacks for several APIs such as WKKeyValueStorageManagerGetKeyValueStorageOrigins.
But only few callbacks really return errors.

So this parameters just make confusion for application developers.
Comment 1 Ryuan Choi 2014-03-21 00:29:32 PDT 
Created attachment 227389 [details]
Patch
Comment 2 Gyuyoung Kim 2014-03-21 00:41:09 PDT 
Comment on attachment 227389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227389&action=review

> Source/WebKit2/ChangeLog:8
> +        WebKit2 internally use GenericCallbacks for several APIs such as WKKeyValueStorageManagerGetKeyValueStorageOrigins.

use - > uses ?

> Source/WebKit2/ChangeLog:11
> +        This patch removed Ewk_Error parameters from these callbask not to make

removed -> removes ?
callbask -> callbacks ?
Comment 3 Ryuan Choi 2014-03-21 00:55:47 PDT 
Created attachment 227394 [details]
Patch
Comment 4 Ryuan Choi 2014-03-21 00:59:03 PDT 
Comment on attachment 227394 [details]
Patch

Clearing flags on attachment: 227394

Committed r166051: <http://trac.webkit.org/changeset/166051>
Comment 5 Ryuan Choi 2014-03-21 00:59:12 PDT 
All reviewed patches have been landed.  Closing bug.