Bug 130534

Summary:

Move cross-port Source/WebCore/page/ code to std::unique_ptr

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, dstockwell, esprehn+autocc, kangil.han, mkwst, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none

Zan Dobersek

Reported 2014-03-20 13:20:43 PDT

Move cross-port Source/WebCore/page/ code to std::unique_ptr

Attachments
Patch (43.97 KB, patch) 2014-03-20 13:40 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (44.98 KB, patch) 2014-03-25 13:43 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (42.94 KB, patch) 2014-04-20 12:24 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch for landing (43.49 KB, patch) 2014-04-21 04:09 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2014-03-20 13:40:40 PDT

Created attachment 227327 [details] Patch

WebKit Commit Bot

Comment 2 2014-03-20 13:43:09 PDT

Attachment 227327 [details] did not pass style-queue: ERROR: Source/WebCore/page/Frame.cpp:165: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/Frame.cpp:166: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:771: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:778: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] Total errors found: 6 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 3 2014-03-25 13:43:12 PDT

Created attachment 227791 [details] Patch

WebKit Commit Bot

Comment 4 2014-03-25 13:44:23 PDT

Attachment 227791 [details] did not pass style-queue: ERROR: Source/WebCore/page/Frame.cpp:165: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/Frame.cpp:166: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:771: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:778: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] Total errors found: 6 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 5 2014-04-16 11:49:04 PDT

Comment on attachment 227791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227791&action=review This looks good, but unfortunately seemed to choke in the EWS system for Mac. Could you rebaseline and upload again so we can confirm it's okay? > Source/WebCore/page/ContentSecurityPolicy.cpp:919 > + std::unique_ptr<CSPDirectiveList> directives(new CSPDirectiveList(policy, type)); Why not auto directives = std::make_unique<CSPDirectiveList>(policy, type)?

Zan Dobersek

Comment 6 2014-04-20 12:24:00 PDT

Created attachment 229773 [details] Patch

WebKit Commit Bot

Comment 7 2014-04-20 12:26:28 PDT

Attachment 229773 [details] did not pass style-queue: ERROR: Source/WebCore/page/Frame.cpp:165: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/Frame.cpp:166: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:769: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:776: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] Total errors found: 6 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 8 2014-04-20 20:46:53 PDT

Comment on attachment 229773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229773&action=review /Volumes/Data/EWS/WebKit/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:485:60: error: reference to type 'const JSC::Yarr::RegularExpression' could not bind to an lvalue of type 'JSC::Yarr::RegularExpression *' r=me as long as you fix the Mac build > Source/WebCore/page/DOMWindow.cpp:158 > + // This object gets deleted when std::unique_ptr falls out of scope.. > + std::unique_ptr<PostMessageTimer> timer(this); > + m_window->postMessageTimerFired(*timer); Not sure this is better than just calling "delete this" at the end of the function. > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1087 > + CSSPropertyAnimationWrapperMap(); Why not leave this private?

Zan Dobersek

Comment 9 2014-04-21 04:09:00 PDT

Created attachment 229797 [details] Patch for landing Should fix the Mac build.

Zan Dobersek

Comment 10 2014-04-21 04:10:38 PDT

Comment on attachment 229773 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229773&action=review >> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1087 >> + CSSPropertyAnimationWrapperMap(); > > Why not leave this private? It was made accessible to the NeverDestroyed constructor, but I now declared NeverDestroyed<CSSPropertyAnimationWrapperMap> as a friend instead.

WebKit Commit Bot

Comment 11 2014-04-21 04:11:55 PDT

Attachment 229797 [details] did not pass style-queue: ERROR: Source/WebCore/page/Frame.cpp:165: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/Frame.cpp:166: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:769: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:770: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:776: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:777: Wrong number of spaces before statement. (expected: 44) [whitespace/indent] [4] Total errors found: 6 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 12 2014-04-21 10:12:12 PDT

Comment on attachment 229797 [details] Patch for landing Clearing flags on attachment: 229797 Committed r167594: <http://trac.webkit.org/changeset/167594>

Zan Dobersek

Comment 13 2014-04-21 10:12:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.