Bug 130517

Summary: [GTK] Suppress errors about using gdk_threads_enter gdk_threads_leave
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch svillar: review+

Description Martin Robinson 2014-03-20 09:49:40 PDT 
These errors are false positives, since we actually need to use the APIs.
Comment 1 Martin Robinson 2014-03-20 09:59:07 PDT 
Created attachment 227298 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-20 10:01:30 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alberto Garcia 2014-03-20 11:34:50 PDT 
(In reply to comment #1)
> Created an attachment (id=227298) [details]
> Patch

lgtm, thanks!
Comment 4 Sergio Villar Senin 2014-03-20 11:43:51 PDT 
Comment on attachment 227298 [details]
Patch

r=me. Consider adding a FIXME to the comments mentioning that all the deprecation warnings will be suppresed.
Comment 5 Sergio Villar Senin 2014-03-20 11:44:18 PDT 
Comment on attachment 227298 [details]
Patch

errrr
Comment 6 Martin Robinson 2014-03-20 20:01:25 PDT 
Committed r166035: <http://trac.webkit.org/changeset/166035>