Bug 130473

Summary: Implement isPointInPath and isPointInStroke with Path2D argument
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, oliver, simon.fraser
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#path
Attachments:
Description Flags
Patch
dino: review+
Patch none

Dirk Schulze
Reported 2014-03-19 14:08:04 PDT
Implement isPointInPath and isPointInStroke with Path2D argument
Attachments
Patch (17.01 KB, patch)
2014-03-19 14:14 PDT, Dirk Schulze 		dino: review+
DetailsFormatted DiffDiff
Patch (19.29 KB, patch)
2014-03-19 15:00 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2014-03-19 14:14:06 PDT
Created attachment 227215 [details] Patch
Dean Jackson
Comment 2 2014-03-19 14:35:04 PDT
Comment on attachment 227215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227215&action=review > LayoutTests/fast/canvas/canvas-path-isPointInPath-expected.txt:12 > +PASS ctx.isPointInPath(null, 50, 50) threw exception TypeError: Argument 3 ('winding') to CanvasRenderingContext2D.isPointInPath must be one of: "nonzero", "evenodd". Discussion on irc suggests this error message is wrong. > LayoutTests/fast/canvas/script-tests/canvas-path-isPointInPath.js:34 > +shouldThrow("ctx.isPointInPath({}, 50, 50, 'nonzero')"); > +shouldThrow("ctx.isPointInPath({}, 50, 50, 'evenodd')"); I would like to see some tests where you are passing in some extremely unexpected data, such as Number.MAX_VALUE or strings, etc.
Dirk Schulze
Comment 3 2014-03-19 15:00:50 PDT
Created attachment 227222 [details] Patch
WebKit Commit Bot
Comment 4 2014-03-19 15:40:09 PDT
Comment on attachment 227222 [details] Patch Clearing flags on attachment: 227222 Committed r165927: <http://trac.webkit.org/changeset/165927>
WebKit Commit Bot
Comment 5 2014-03-19 15:40:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.