Implement isPointInPath and isPointInStroke with Path2D argument

[Dirk Schulze]

Implement isPointInPath and isPointInStroke with Path2D argument

[Dirk Schulze]

Created attachment 227215 [details]
Patch

[Dean Jackson]

Comment on attachment 227215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227215&action=review

> LayoutTests/fast/canvas/canvas-path-isPointInPath-expected.txt:12
> +PASS ctx.isPointInPath(null, 50, 50) threw exception TypeError: Argument 3 ('winding') to CanvasRenderingContext2D.isPointInPath must be one of: "nonzero", "evenodd".

Discussion on irc suggests this error message is wrong.

> LayoutTests/fast/canvas/script-tests/canvas-path-isPointInPath.js:34
> +shouldThrow("ctx.isPointInPath({}, 50, 50, 'nonzero')");
> +shouldThrow("ctx.isPointInPath({}, 50, 50, 'evenodd')");

I would like to see some tests where you are passing in some extremely unexpected data, such as Number.MAX_VALUE or strings, etc.

[Dirk Schulze]

Created attachment 227222 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 227222 [details]
Patch

Clearing flags on attachment: 227222

Committed r165927: <http://trac.webkit.org/changeset/165927>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.