Bug 130472

Summary:

Build Soup files on Windows

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

bfulgham, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 8

Attachments:

Description	Flags
Patch	bfulgham: review+

Alex Christensen

Reported 2014-03-19 14:05:38 PDT

I'm working on using Soup on Windows. I know the purpose of putting files in curl or soup subdirectories is so that we don't have to use #if USE(SOUP) and #if USE(CURL) macros, but this is the easiest solution I can think of without adding another build system.

Attachments
Patch (39.99 KB, patch) 2014-03-19 14:09 PDT, Alex Christensen	bfulgham: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2014-03-19 14:09:55 PDT

Created attachment 227214 [details] Patch

Brent Fulgham

Comment 2 2014-03-20 13:41:41 PDT

Comment on attachment 227214 [details] Patch Looks fine to me.

Alex Christensen

Comment 3 2014-03-20 13:56:05 PDT

http://trac.webkit.org/changeset/165996

Note You need to log in before you can comment on or make changes to this bug.