Bug 130472 - Build Soup files on Windows
Summary: Build Soup files on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-19 14:05 PDT by Alex Christensen
Modified: 2014-03-20 13:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (39.99 KB, patch)
2014-03-19 14:09 PDT, Alex Christensen 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-03-19 14:05:38 PDT 
I'm working on using Soup on Windows.  I know the purpose of putting files in curl or soup subdirectories is so that we don't have to use #if USE(SOUP) and #if USE(CURL) macros, but this is the easiest solution I can think of without adding another build system.
Comment 1 Alex Christensen 2014-03-19 14:09:55 PDT 
Created attachment 227214 [details]
Patch
Comment 2 Brent Fulgham 2014-03-20 13:41:41 PDT 
Comment on attachment 227214 [details]
Patch

Looks fine to me.
Comment 3 Alex Christensen 2014-03-20 13:56:05 PDT 
http://trac.webkit.org/changeset/165996