Bug 130469

Summary: Build fails when 3d rendering is disabled
Product: WebKit Reporter: Tomeu Vizoso <tomeu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: aperez, bugs-noreply, commit-queue, dino, kondapallykalyan, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review-

Tomeu Vizoso
Reported 2014-03-19 10:43:46 PDT
Because of missing USE(3D_GRAPHICS) guards.
Attachments
Patch (1.99 KB, patch)
2014-03-19 10:45 PDT, Tomeu Vizoso 		bfulgham: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomeu Vizoso
Comment 1 2014-03-19 10:45:33 PDT
Created attachment 227197 [details] Patch
Brent Fulgham
Comment 2 2016-03-14 11:13:14 PDT
Comment on attachment 227197 [details] Patch This patch seems reasonable. However, it's a few years out of date. Can this be updated so that it applies and works with current sources?
Adrian Perez
Comment 3 2022-03-01 01:41:33 PST
The files referenced by the patch are long gone, and IIUC the replacement is GraphicsContextGL.h and friends, which do have guards covering the whole file, for example ENABLE(WEBGL) for GraphicsContextGL.h
Note You need to log in before you can comment on or make changes to this bug.