Bug 130469

Summary:

Build fails when 3d rendering is disabled

Product:

WebKit

Reporter:

Tomeu Vizoso <tomeu>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

aperez, bugs-noreply, commit-queue, dino, kondapallykalyan, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bfulgham: review-

Description Tomeu Vizoso 2014-03-19 10:43:46 PDT

Because of missing USE(3D_GRAPHICS) guards.

Comment 1 Tomeu Vizoso 2014-03-19 10:45:33 PDT

Created attachment 227197 [details]
Patch

Comment 2 Brent Fulgham 2016-03-14 11:13:14 PDT

Comment on attachment 227197 [details]
Patch

This patch seems reasonable. However, it's a few years out of date. Can this be updated so that it applies and works with current sources?

Comment 3 Adrian Perez 2022-03-01 01:41:33 PST

The files referenced by the patch are long gone, and IIUC the
replacement is GraphicsContextGL.h and friends, which do have
guards covering the whole file, for example ENABLE(WEBGL) for
GraphicsContextGL.h