Bug 130466

Summary:

[GTK][CMake] CMake build fails to link TestNetscapePlugIn

Product:

WebKit

Reporter:

Tomeu Vizoso <tomeu>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bunhere, cgarcia, commit-queue, gyuyoung.kim, mcatanzaro, mrobinson, rakuco, sergio, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mcatanzaro: review-, mcatanzaro: commit-queue-

Tomeu Vizoso

Reported 2014-03-19 10:24:23 PDT

Because of missing -lX11

Attachments
Patch (2.05 KB, patch) 2014-03-19 10:30 PDT, Tomeu Vizoso	no flags	Details Formatted Diff Diff
Patch (2.07 KB, patch) 2014-03-19 10:50 PDT, Tomeu Vizoso	mcatanzaro: review- mcatanzaro: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tomeu Vizoso

Comment 1 2014-03-19 10:27:10 PDT

*** Bug 130462 has been marked as a duplicate of this bug. ***

Tomeu Vizoso

Comment 2 2014-03-19 10:27:25 PDT

*** Bug 130465 has been marked as a duplicate of this bug. ***

Tomeu Vizoso

Comment 3 2014-03-19 10:30:02 PDT

Created attachment 227192 [details] Patch

WebKit Commit Bot

Comment 4 2014-03-19 10:32:58 PDT

Attachment 227192 [details] did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tomeu Vizoso

Comment 5 2014-03-19 10:50:57 PDT

Created attachment 227199 [details] Patch

Martin Robinson

Comment 6 2014-03-22 20:45:42 PDT

Comment on attachment 227199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review > Source/cmake/OptionsGTK.cmake:169 > +# FIXME: This is needed just for TestNetscapePlugIn, which calls X directly. > +find_package(X11 REQUIRED) > + Why is this necessary? CMake already looks for X11 libraries by default.

Michael Catanzaro

Comment 7 2016-01-03 17:15:38 PST

Comment on attachment 227199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review Sorry this went unreviewed for so long. :( >> Source/cmake/OptionsGTK.cmake:169 >> + > > Why is this necessary? CMake already looks for X11 libraries by default. We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so.... > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41 > + ${X11_X11_LIB} And DRT is no longer used by the GTK+ port, so I think this patch is obsolete.

Note You need to log in before you can comment on or make changes to this bug.