Bug 130466

Summary: [GTK][CMake] CMake build fails to link TestNetscapePlugIn
Product: WebKit Reporter: Tomeu Vizoso <tomeu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bunhere, cgarcia, commit-queue, gyuyoung.kim, mcatanzaro, mrobinson, rakuco, sergio, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review-, mcatanzaro: commit-queue-

Description Tomeu Vizoso 2014-03-19 10:24:23 PDT 
Because of missing -lX11
Comment 1 Tomeu Vizoso 2014-03-19 10:27:10 PDT 
*** Bug 130462 has been marked as a duplicate of this bug. ***
Comment 2 Tomeu Vizoso 2014-03-19 10:27:25 PDT 
*** Bug 130465 has been marked as a duplicate of this bug. ***
Comment 3 Tomeu Vizoso 2014-03-19 10:30:02 PDT 
Created attachment 227192 [details]
Patch
Comment 4 WebKit Commit Bot 2014-03-19 10:32:58 PDT 
Attachment 227192 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tomeu Vizoso 2014-03-19 10:50:57 PDT 
Created attachment 227199 [details]
Patch
Comment 6 Martin Robinson 2014-03-22 20:45:42 PDT 
Comment on attachment 227199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

> Source/cmake/OptionsGTK.cmake:169
> +# FIXME: This is needed just for TestNetscapePlugIn, which calls X directly.
> +find_package(X11 REQUIRED)
> +

Why is this necessary? CMake already looks for X11 libraries by default.
Comment 7 Michael Catanzaro 2016-01-03 17:15:38 PST 
Comment on attachment 227199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227199&action=review

Sorry this went unreviewed for so long. :(

>> Source/cmake/OptionsGTK.cmake:169
>> +
> 
> Why is this necessary? CMake already looks for X11 libraries by default.

We wound up adding this earlier this year, for compatibility with newer CMake, but guarded by if (ENABLE_X11_TARGET). Anyway, it doesn't need to be added anymore, because we already have done so....

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:41
> +    ${X11_X11_LIB}

And DRT is no longer used by the GTK+ port, so I think this patch is obsolete.