Summary: | WebKit2 View Gestures: Swipe gesture can track vertical movement instead of horizontal movement | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, sam, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-03-18 19:25:36 PDT
Created attachment 227147 [details]
patch
Created attachment 227152 [details]
patch that builds
Comment on attachment 227152 [details] patch that builds View in context: https://bugs.webkit.org/attachment.cgi?id=227152&action=review > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:267 > if (!event.hasPreciseScrollingDeltas) > return false; > > if (![NSEvent isSwipeTrackingFromScrollEventsEnabled]) > return false; Would be cheaper to do these early returns sooner. > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:279 > + m_hasPendingSwipe = false; Does this need to be cleared before the previous return? |