ViewGestureController::handleScrollWheelEvent properly bails in a wide variety of cases, but wheelEventWasNotHandledByWebCore does not, so we can pick up a wheel event that was rejected by the web process (and would have been rejected by the checks in handleScrollWheelEvent) and use it to start tracking a swipe. One of the cases we check in handleScrollWheelEvent is that the horizontal delta is bigger; since we don't check this in wheelEventWasNotHandledByWebCore, we can start tracking a swipe from an event with a predominantly vertical delta, which results in the swipe tracking vertical movement instead of horizontal movement. We should factor out all of the cases and check in both places. <rdar://problem/16337279>
Created attachment 227147 [details] patch
Created attachment 227152 [details] patch that builds
Comment on attachment 227152 [details] patch that builds View in context: https://bugs.webkit.org/attachment.cgi?id=227152&action=review > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:267 > if (!event.hasPreciseScrollingDeltas) > return false; > > if (![NSEvent isSwipeTrackingFromScrollEventsEnabled]) > return false; Would be cheaper to do these early returns sooner. > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:279 > + m_hasPendingSwipe = false; Does this need to be cleared before the previous return?
http://trac.webkit.org/changeset/165903