Bug 130433

Summary: Add new functionality that will be required by the history item decoding
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2014-03-18 16:55:08 PDT
Add new functionality that will be required by the history item decoding
Comment 1 Anders Carlsson 2014-03-18 16:56:43 PDT
Created attachment 227132 [details]
Patch
Comment 2 Sam Weinig 2014-03-18 19:36:35 PDT
Comment on attachment 227132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227132&action=review

> Source/WebCore/platform/KeyedCoding.h:79
> +        // FIXME: This doesn't distinguish between a missing object dictionary or a value of a different type.

This took me a bit to parse.  I would add a little bit more information about how its beginObject() doesn't distinguish and why return true.
Comment 3 Anders Carlsson 2014-03-19 10:37:02 PDT
Committed r165900: <http://trac.webkit.org/changeset/165900>